linux-kernel - Re: [PATCH v1 2/2] clk: qcom: sc7280: Update clk_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220205024828.76942C004E1@smtp.kernel.org>
Date:   Fri, 04 Feb 2022 18:48:26 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Taniya Das <tdas@...eaurora.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] clk: qcom: sc7280: Update clk_init_data to const for clock controllers

Quoting Dmitry Baryshkov (2022-02-02 14:34:11)
> On Wed, 2 Feb 2022 at 21:23, Taniya Das <tdas@...eaurora.org> wrote:
> >
> > Update clk_init_data to const and also use index instead of fw_name for
> > graphics, lpasscc and video clock controller.
> 
> What is the benefit from using indices here? In my opinion the code
> becomes more fragile with such a change.

The benefit is smaller code size. Please run scripts/bloat-o-meter