linux-kernel - Re: [PATCH v7 net-next 05/10] net: dsa: microchip: add DSA support for microchip lan937x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220204192734.0c2c5e95@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 4 Feb 2022 19:27:34 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
Cc:     <andrew@...n.ch>, <netdev@...r.kernel.org>, <olteanv@...il.com>,
        <robh+dt@...nel.org>, <UNGLinuxDriver@...rochip.com>,
        <Woojung.Huh@...rochip.com>, <hkallweit1@...il.com>,
        <linux@...linux.org.uk>, <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <vivien.didelot@...il.com>,
        <f.fainelli@...il.com>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v7 net-next 05/10] net: dsa: microchip: add DSA support
 for microchip lan937x

On Fri, 4 Feb 2022 23:14:55 +0530 Prasanna Vengateshan wrote:
> Basic DSA driver support for lan937x and the device will be
> configured through SPI interface.
> 
> drivers/net/dsa/microchip/ path is already part of MAINTAINERS &
> the new files come under this path. Hence no update needed to the
> MAINTAINERS
> 
> Reused KSZ APIs for port_bridge_join() & port_bridge_leave() and
> added support for port_stp_state_set() & port_fast_age().
> 
> lan937x_flush_dyn_mac_table() which gets called from
> port_fast_age() of KSZ common layer, hence added support for it.
> 
> RGMII internal delay values for the mac is retrieved from
> rx-internal-delay-ps & tx-internal-delay-ps as per the feedback from
> v3 patch series.
> https://lore.kernel.org/netdev/20210802121550.gqgbipqdvp5x76ii@skbuf/
> 
> It supports standard delay 2ns only. If the property is not found, the value
> will be forced to 0.
> 
> Signed-off-by: Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>


drivers/net/dsa/microchip/lan937x_dev.c:162:6: warning: no previous prototype for ‘lan937x_r_mib_pkt’ [-Wmissing-prototypes]
  162 | void lan937x_r_mib_pkt(struct ksz_device *dev, int port, u16 addr,
      |      ^~~~~~~~~~~~~~~~~