linux-kernel - Re: [PATCH] IOMMU: Intel: DMAR: Replace acpi_bus_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9915edbf-ccda-be71-87a0-0c74c683d3d8@linux.intel.com>
Date:   Sat, 5 Feb 2022 11:31:31 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        David Woodhouse <dwmw2@...radead.org>
Cc:     baolu.lu@...ux.intel.com, LKML <linux-kernel@...r.kernel.org>,
        Linux ACPI <linux-acpi@...r.kernel.org>,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        iommu@...ts.linux-foundation.org
Subject: Re: [PATCH] IOMMU: Intel: DMAR: Replace acpi_bus_get_device()

On 2022/2/2 2:11, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Replace acpi_bus_get_device() that is going to be dropped with
> acpi_fetch_acpi_dev().
> 
> No intentional functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>   drivers/iommu/intel/dmar.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: linux-pm/drivers/iommu/intel/dmar.c
> ===================================================================
> --- linux-pm.orig/drivers/iommu/intel/dmar.c
> +++ linux-pm/drivers/iommu/intel/dmar.c
> @@ -789,7 +789,8 @@ static int __init dmar_acpi_dev_scope_in
>   				       andd->device_name);
>   				continue;
>   			}
> -			if (acpi_bus_get_device(h, &adev)) {
> +			adev = acpi_fetch_acpi_dev(h);
> +			if (!adev) {
>   				pr_err("Failed to get device for ACPI object %s\n",
>   				       andd->device_name);
>   				continue;

Please adjust the patch title to "iommu/vtd: Replace acpi_bus_get_device()"

Reviewed-by: Lu Baolu <baolu.lu@...ux.intel.com>

Best regards,
baolu