linux-kernel - RE: [PATCH] staging: octeon-usb: Fix 'should not end with '(''

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 6 Feb 2022 14:16:26 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     "'joelcchangg@...il.com'" <joelcchangg@...il.com>,
        "linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "gregkh@...uxfoundation.com" <gregkh@...uxfoundation.com>
Subject: RE: [PATCH] staging: octeon-usb: Fix 'should not end with '(''

From: joelcchangg@...il.com
> Sent: 06 February 2022 07:46
> 
> This patch fixes the checkpatch.pl check:
> 
> CHECK: Line should not end with '('
> 
> at lines 1802, 1807 and at some function headers.
> 
> Signed-off-by: Joel Camilo Chang Gonzalez <joelcchangg@...il.com>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 67 +++++++++++--------------
>  1 file changed, 29 insertions(+), 38 deletions(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index a1cd81d4a114..60e8354104e6 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -1792,23 +1792,18 @@ static void cvmx_usb_start_channel(struct octeon_hcd *usb, int channel,
>  	case CVMX_USB_TRANSFER_INTERRUPT:
>  		break;
>  	case CVMX_USB_TRANSFER_ISOCHRONOUS:
> -		if (!cvmx_usb_pipe_needs_split(usb, pipe)) {
> +		if (!cvmx_usb_pipe_needs_split(usb, pipe) &&
> +		    pipe->transfer_dir == CVMX_USB_DIRECTION_OUT) {
>  			/*
>  			 * ISO transactions require different PIDs depending on
>  			 * direction and how many packets are needed
>  			 */
> -			if (pipe->transfer_dir == CVMX_USB_DIRECTION_OUT) {
> -				if (pipe->multi_count < 2) /* Need DATA0 */
> -					USB_SET_FIELD32(
> -						CVMX_USBCX_HCTSIZX(channel,
> -								   usb->index),
> +			if (pipe->multi_count < 2) /* Need DATA0 */
> +				USB_SET_FIELD32(CVMX_USBCX_HCTSIZX(channel, usb->index),
>  						cvmx_usbcx_hctsizx, pid, 0);
> -				else /* Need MDATA */
> -					USB_SET_FIELD32(
> -						CVMX_USBCX_HCTSIZX(channel,
> -								   usb->index),
> +			else /* Need MDATA */
> +				USB_SET_FIELD32(CVMX_USBCX_HCTSIZX(channel, usb->index),
>  						cvmx_usbcx_hctsizx, pid, 3);
> -			}
>  		}
>  		break;
>  	}

What has that hunk got to do with the patch description?

> @@ -2121,17 +2116,17 @@ static void cvmx_usb_complete(struct octeon_hcd *usb,
>   *
>   * Returns: Transaction or NULL on failure.
>   */
> -static struct cvmx_usb_transaction *cvmx_usb_submit_transaction(
> -				struct octeon_hcd *usb,
> -				struct cvmx_usb_pipe *pipe,
> -				enum cvmx_usb_transfer type,
> -				u64 buffer,
> -				int buffer_length,
> -				u64 control_header,
> -				int iso_start_frame,
> -				int iso_number_packets,
> -				struct cvmx_usb_iso_packet *iso_packets,
> -				struct urb *urb)
> +static struct cvmx_usb_transaction *cvmx_usb_submit_transaction(struct octeon_hcd *usb,
> +								struct cvmx_usb_pipe *pipe,
> +								enum cvmx_usb_transfer type,
> +								u64 buffer,
> +								int buffer_length,
> +								u64 control_header,
> +								int iso_start_frame,
> +								int iso_number_packets,
> +								struct cvmx_usb_iso_packet
> +									*iso_packets,
> +								struct urb *urb)

Those lines are now far longer than is 'nice'.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)