linux-kernel - Re: [PATCH v3 7/8] memory: of: parse max-freq property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6af1977-51d5-527d-669f-d71cd0fcb64f@gmail.com>
Date:   Sun, 6 Feb 2022 18:33:48 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Rob Herring <robh+dt@...nel.org>,
        Lukasz Luba <lukasz.luba@....com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 7/8] memory: of: parse max-freq property

06.02.2022 16:58, Krzysztof Kozlowski пишет:
> Passing the memory timings maximum frequency as an unit address was
> a workaround and instead 'max-freq' is preferred.  Look for 'max-freq'
> first and then fallback to 'reg'.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
>  drivers/memory/of_memory.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/memory/of_memory.c b/drivers/memory/of_memory.c
> index b94408954d85..bac5c7f34936 100644
> --- a/drivers/memory/of_memory.c
> +++ b/drivers/memory/of_memory.c
> @@ -212,8 +212,10 @@ static int of_lpddr3_do_get_timings(struct device_node *np,
>  {
>  	int ret;
>  
> -	/* The 'reg' param required since DT has changed, used as 'max-freq' */
> -	ret = of_property_read_u32(np, "reg", &tim->max_freq);
> +	ret = of_property_read_u32(np, "max-freq", &tim->max_freq);
> +	if (ret)
> +		/* Deprecated way of passing max-freq as 'reg' */
> +		ret = of_property_read_u32(np, "reg", &tim->max_freq);
>  	ret |= of_property_read_u32(np, "min-freq", &tim->min_freq);
>  	ret |= of_property_read_u32(np, "tRFC", &tim->tRFC);
>  	ret |= of_property_read_u32(np, "tRRD", &tim->tRRD);

Reviewed-by: Dmitry Osipenko <digetx@...il.com>