linux-kernel - Re: [RFC PATCH 3/5] firmware_loader: Split fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <487b45dc-edd3-4406-7f06-9dc68e330623@redhat.com>
Date:   Sun, 6 Feb 2022 07:43:25 -0800
From:   Tom Rix <trix@...hat.com>
To:     Russ Weight <russell.h.weight@...el.com>, mcgrof@...nel.org,
        gregkh@...uxfoundation.org, rafael@...nel.org,
        linux-kernel@...r.kernel.org
Cc:     lgoncalv@...hat.com, yilun.xu@...el.com, hao.wu@...el.com,
        matthew.gerlach@...el.com, basheer.ahmed.muddebihal@...el.com,
        tianfei.zhang@...el.com
Subject: Re: [RFC PATCH 3/5] firmware_loader: Split fw_sysfs support from
 fallback


On 2/3/22 1:30 PM, Russ Weight wrote:
> In preparation for sharing the "loading" and "data" sysfs nodes with the
> new firmware upload support, split out sysfs functionality from fallback.c
> and fallback.h into fw_sysfs.c and fw_sysfs.h. This includes the firmware
> class driver code that is associated with the sysfs files and the
> fw_fallback_config support for the timeout sysfs node.
>
> CONFIG_FW_LOADER_SYSFS is created and is selected by
> CONFIG_FW_LOADER_USER_HELPER in order to include fw_sysfs.o in
> firmware_class-objs.
>
> This is mostly just a code reorganization. There are a few symbols that
> change in scope, and these can be identified by looking at the header
> file changes. A few white-space warnings from checkpatch are also
> addressed in this patch.
>
> Signed-off-by: Russ Weight <russell.h.weight@...el.com>

Consider how bisectable and reviewable this patch is.

I think this patch should be first since reorganizing should not depend 
on anything new.

Other users of fallback will want to know if this change is going to 
break them, so the reorganization should be as mechanical as possible to 
make the review as easy as possible and easy to revert if something goes 
wrong.  Ex/ the whitespace changes made as a separate patch to the old 
file, not embedded in the new file.  The new Kconfig added later if needed.

Also consider if this move is needed at all, generalizing in the 
existing file is ok.

Tom