linux-kernel - Re: [PATCH v2 4/5] dt-bindings: memory: lpddr3-timings: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5bbf115-21a2-7d63-6744-72487b9e756a@canonical.com>
Date:   Sun, 6 Feb 2022 12:20:30 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Dmitry Osipenko <digetx@...il.com>,
        Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: memory: lpddr3-timings: convert to
 dtschema

On 05/02/2022 19:50, Dmitry Osipenko wrote:
> 05.02.2022 15:00, Krzysztof Kozlowski пишет:
>> +  reg:
>> +    maxItems: 1
>> +    description: |
>> +      Maximum DDR clock frequency for the speed-bin, in Hz.
> 
> Why max-freq is specified as a register? At minimum this is inconsistent
> with the lpddr2 binding.

First of all, this is a conversion, so the bindings already specified
max-freq that way.
Second, I don't know. I think this was some Lukasz's workaround for
device node without unit address, but I don't see the reason now why it
was needed.

We could unify it with DDR2 by deprecating 'reg' and introducing
'max-freq', in separate commit. But you know, existing bindings are
already there...

Best regards,
Krzysztof