linux-kernel - RE: [EXT] [PATCH] qedi: Remove redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO6PR18MB44195156F85CBE435DA1D5A3D82C9@CO6PR18MB4419.namprd18.prod.outlook.com>
Date:   Mon, 7 Feb 2022 04:47:44 +0000
From:   Manish Rangankar <mrangankar@...vell.com>
To:     "cgel.zte@...il.com" <cgel.zte@...il.com>
CC:     GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Minghao Chi (CGEL ZTE)" <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: RE: [EXT] [PATCH] qedi: Remove redundant 'flush_workqueue()' calls


> -----Original Message-----
> From: cgel.zte@...il.com <cgel.zte@...il.com>
> Sent: Thursday, January 27, 2022 7:10 AM
> To: Nilesh Javali <njavali@...vell.com>
> Cc: Manish Rangankar <mrangankar@...vell.com>; GR-QLogic-Storage-
> Upstream <GR-QLogic-Storage-Upstream@...vell.com>; jejb@...ux.ibm.com;
> martin.petersen@...cle.com; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org; Minghao Chi (CGEL ZTE) <chi.minghao@....com.cn>;
> Zeal Robot <zealci@....com.cn>; CGEL ZTE <cgel.zte@...il.com>
> Subject: [EXT] [PATCH] qedi: Remove redundant 'flush_workqueue()' calls
> 
> External Email
> 
> ----------------------------------------------------------------------
> From: "Minghao Chi (CGEL ZTE)" <chi.minghao@....com.cn>
> 
> 'destroy_workqueue()' already drains the queue before destroying it, so there is
> no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@....com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@...il.com>
> ---
>  drivers/scsi/qedi/qedi_main.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index
> 832a856dd367..83ffba7f51da 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -2418,13 +2418,11 @@ static void __qedi_remove(struct pci_dev *pdev,
> int mode)
>  		iscsi_host_remove(qedi->shost);
> 
>  		if (qedi->tmf_thread) {
> -			flush_workqueue(qedi->tmf_thread);
>  			destroy_workqueue(qedi->tmf_thread);
>  			qedi->tmf_thread = NULL;
>  		}
> 
>  		if (qedi->offload_thread) {
> -			flush_workqueue(qedi->offload_thread);
>  			destroy_workqueue(qedi->offload_thread);
>  			qedi->offload_thread = NULL;
>  		}

Thanks,

Acked-by: Manish Rangankar <mrangankar@...vell.com>