linux-kernel - Re: [PATCH] lib/test_string.c: return -ENOMEM on memset16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YgENYYPT2gs7sX8H@smile.fi.intel.com>
Date:   Mon, 7 Feb 2022 14:15:29 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     andy@...nel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] lib/test_string.c: return -ENOMEM on memset16_selftest
 allocation failure

On Mon, Feb 07, 2022 at 06:36:26PM +0800, Jiapeng Chong wrote:
> Clean up the following smatch warning:
> 
> lib/test_string.c:14 memset16_selftest() warn: returning -1 instead of
> -ENOMEM is sloppy.

It's not that makes much difference, but fine
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  lib/test_string.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/test_string.c b/lib/test_string.c
> index 9dfd6f52de92..f23d6cd2d9c7 100644
> --- a/lib/test_string.c
> +++ b/lib/test_string.c
> @@ -11,7 +11,7 @@ static __init int memset16_selftest(void)
>  
>  	p = kmalloc(256 * 2 * 2, GFP_KERNEL);
>  	if (!p)
> -		return -1;
> +		return -ENOMEM;
>  
>  	for (i = 0; i < 256; i++) {
>  		for (j = 0; j < 256; j++) {
> -- 
> 2.20.1.7.g153144c
> 

-- 
With Best Regards,
Andy Shevchenko