linux-kernel - [PATCH][next] intel_th: remove redundant early initialization of pointer hubdrv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon,  7 Feb 2022 13:47:51 +0000
From:   Colin Ian King <colin.i.king@...il.com>
To:     Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH][next] intel_th: remove redundant early initialization of pointer hubdrv

Pointer hubdrv is being initialized with a value that is never read,
it is being re-assigned the same value later on closer to where it
is being first used. The initialization is redundant and can be
removed.

Signed-off-by: Colin Ian King <colin.i.king@...il.com>
---
 drivers/hwtracing/intel_th/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th/core.c
index 7e753a75d23b..f8fa0bd414fb 100644
--- a/drivers/hwtracing/intel_th/core.c
+++ b/drivers/hwtracing/intel_th/core.c
@@ -1037,7 +1037,7 @@ int intel_th_set_output(struct intel_th_device *thdev,
 			unsigned int master)
 {
 	struct intel_th_device *hub = to_intel_th_hub(thdev);
-	struct intel_th_driver *hubdrv = to_intel_th_driver(hub->dev.driver);
+	struct intel_th_driver *hubdrv;
 	int ret;
 
 	/* In host mode, this is up to the external debugger, do nothing. */
-- 
2.34.1