linux-kernel - Re: [PATCH] Fix perf_mmap fail when CONFIG_PERF_USE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220207141136.GG23216@worktop.programming.kicks-ass.net>
Date:   Mon, 7 Feb 2022 15:11:36 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Zhipeng Xie <xiezhipeng1@...wei.com>
Cc:     mingo@...hat.com, acme@...nel.org, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix perf_mmap fail when CONFIG_PERF_USE_VMALLOC enabled


Your $Subject needs a subsystem prefix.

On Mon, Feb 07, 2022 at 12:02:59PM -0500, Zhipeng Xie wrote:
> when CONFIG_PERF_USE_VMALLOC is enabled, rb->nr_pages is always
> equal to 1 in rb_alloc, causing perf_mmap return -EINVAL when mmap.
> Fix this problem using data_page_nr.

How can this be? This would mean that any arch that selects that hasn't
worked for forever ?! That seems unlikely.

> Signed-off-by: Zhipeng Xie <xiezhipeng1@...wei.com>

If this is correct; this is also missing a Fixes: tag.