linux-kernel - Re: [PATCH v7 01/17] KVM: s390: pv: leak the topmost page table when destroy fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Feb 2022 15:33:15 +0100
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     Janosch Frank <frankja@...ux.ibm.com>
Cc:     Claudio Imbrenda <imbrenda@...ux.ibm.com>, kvm@...r.kernel.org,
        borntraeger@...ibm.com, thuth@...hat.com, pasic@...ux.ibm.com,
        david@...hat.com, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, scgl@...ux.ibm.com
Subject: Re: [PATCH v7 01/17] KVM: s390: pv: leak the topmost page table when
 destroy fails

> > +	asce = (gmap->asce & ~PAGE_MASK) | __pa(table);
> 
> Please add a comment:
> Set the new table origin while preserving ASCE control bits like table type
> and length.

And while touching this anyway, please make use of _ASCE_ORIGIN
instead of PAGE_MASK.