linux-kernel - Re: [PATCH v2 3/3] vstatus: Display an informational message when the VSTATUS character is pressed or TIOCSTAT ioctl is called.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35f29dbd-04ec-037e-007c-7a079caf0d5b@kernel.org>
Date:   Mon, 7 Feb 2022 06:38:16 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Walt Drummond <walt@...mmond.us>, agordeev@...ux.ibm.com,
        arnd@...db.de, benh@...nel.crashing.org, borntraeger@...ibm.com,
        chris@...kel.net, davem@...emloft.net, gregkh@...uxfoundation.org,
        hca@...ux.ibm.com, deller@....de, ink@...assic.park.msu.ru,
        James.Bottomley@...senPartnership.com, mattst88@...il.com,
        jcmvbkbc@...il.com, mpe@...erman.id.au, paulus@...ba.org,
        rth@...ddle.net, dalias@...c.org, tsbogend@...ha.franken.de,
        gor@...ux.ibm.com, ysato@...rs.osdn.me
Cc:     linux-kernel@...r.kernel.org, ar@...msu.ru,
        linux-alpha@...r.kernel.org, linux-arch@...r.kernel.org,
        linux-ia64@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
        linux-xtensa@...ux-xtensa.org, sparclinux@...r.kernel.org
Subject: Re: [PATCH v2 3/3] vstatus: Display an informational message when the
 VSTATUS character is pressed or TIOCSTAT ioctl is called.

On 06. 02. 22, 16:48, Walt Drummond wrote:
> When triggered by pressing the VSTATUS key or calling the TIOCSTAT
> ioctl, the n_tty line discipline will display a message on the user's
> tty that provides basic information about the system and an
> 'interesting' process in the current foreground process group, eg:
> 
>    load: 0.58  cmd: sleep 744474 [sleeping] 0.36r 0.00u 0.00s 0% 772k
> 
> The status message provides:
>   - System load average
>   - Command name and process id (from the perspective of the session)
>   - Scheduler state
>   - Total wall-clock run time
>   - User space run time
>   - System space run time
>   - Percentage of on-cpu time
>   - Resident set size
> 
> The message is only displayed when the tty has the VSTATUS character
> set, the local flags ICANON and IEXTEN are enabled and NOKERNINFO is
> disabled; it is always displayed when TIOCSTAT is called regardless of
> tty settings.
> 
> Signed-off-by: Walt Drummond <walt@...mmond.us>
> ---

It looks like my comments were addressed. However you did not document 
the chances since v1 here. IOW, [v2] tag missing here.

And please add the CCs I added last time, so that relevant people still 
can comment.

thanks,
-- 
js
suse labs