linux-kernel - Re: [PATCH next] dt-bindings:spi: Fix test error for sp7021.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a49f77c8-3d92-8c84-28fe-0e6735f09610@canonical.com>
Date:   Mon, 7 Feb 2022 16:45:25 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Li-hao Kuo <lhjeff911@...il.com>, broonie@...nel.org,
        robh+dt@...nel.org, linux-spi@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     wells.lu@...plus.com, lh.kuo@...plus.com
Subject: Re: [PATCH next] dt-bindings:spi: Fix test error for sp7021.

On 07/02/2022 02:46, Li-hao Kuo wrote:
> Remove the include path and modify parameters for fix error for bt binding test

1. No trailing dots in commit title. Space after each ":".
2. s/bt/dt/
3. Wrap the commit msg:
https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L124

4. What is exactly the error you are fixing?

> 
> Fixes: a708078eeb99  ("spi: Add Sunplus SP7021 schema")

5. Only one space after SHA.

6. Wasn't it reported to you? Looks like it was, so you need to add
"Reported-by" tag:
https://lore.kernel.org/all/CAL_JsqKwg_bzJmehTG8tR2cpr+HwwvpF_cpoESidZouc_SpKcQ@mail.gmail.com/

> Signed-off-by: Li-hao Kuo <lhjeff911@...il.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> index 38589fd..298eac2 100644
> --- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> @@ -59,8 +59,6 @@ unevaluatedProperties: false
>  
>  examples:
>    - |
> -    #include <dt-bindings/clock/sp-sp7021.h>
> -    #include <dt-bindings/reset/sp-sp7021.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
>      spi@...02D80 {
>          compatible = "sunplus,sp7021-spi";
> @@ -73,8 +71,8 @@ examples:
>          interrupts = <144 IRQ_TYPE_LEVEL_HIGH>,
>                       <146 IRQ_TYPE_LEVEL_HIGH>,
>                       <145 IRQ_TYPE_LEVEL_HIGH>;
> -        clocks = <&clkc SPI_COMBO_0>;
> -        resets = <&rstc RST_SPI_COMBO_0>;
> +        clocks = <&clkc 0x32>;
> +        resets = <&rstc 0x22>;
>          pinctrl-names = "default";
>          pinctrl-0 = <&pins_spi0>;
>      };


Best regards,
Krzysztof