linux-kernel - Re: [PATCH] ALSA: usb-audio: remove redundant assignment to variable c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hsfsuu07o.wl-tiwai@suse.de>
Date:   Mon, 07 Feb 2022 17:10:19 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: remove redundant assignment to variable c

On Mon, 07 Feb 2022 15:06:17 +0100,
Colin Ian King wrote:
> 
> The variable c is being initialized in an outer for-loop and also
> re-initialized inside an inner for-loop. The first initialization
> is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

The code change looks OK, but when I apply your patch now, git-am
converts the Author address to your new @intel.com, and this
mismatches with the address in Signed-off-by.  Should I keep the
original gmail address, or would you fix up your Signed-off-by (and
From) for avoiding those inconsistency?


thanks,

Takashi