linux-kernel - Re: [PATCH] Staging: wfx: CHECK: usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgFM1HHs7rSqp/0Q@kroah.com>
Date:   Mon, 7 Feb 2022 17:46:12 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Leonardo Araujo <leonardo.aa88@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] Staging: wfx: CHECK: usleep_range is preferred over
 udelay

On Mon, Feb 07, 2022 at 01:00:51PM -0300, Leonardo Araujo wrote:
> Fixes the checks reported by checkpatch.pl for usleep_range.
> 
> Signed-off-by: Leonardo Araujo <leonardo.aa88@...il.com>
> ---
>  drivers/staging/wfx/bh.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c
> index a0f9d1b53019..ebc7eaf93ef0 100644
> --- a/drivers/staging/wfx/bh.c
> +++ b/drivers/staging/wfx/bh.c
> @@ -312,7 +312,7 @@ void wfx_bh_poll_irq(struct wfx_dev *wdev)
>  			dev_err(wdev->dev, "time out while polling control register\n");
>  			return;
>  		}
> -		udelay(200);
> +		usleep_range(200, 200);

Do you have the hardware to verify that this is the correct fix for
this?

You can not just blindly make this type of change here, sorry, otherwise
we would have done so long ago with a simple search/replace :)

thanks,

greg k-h