linux-kernel - Re: [PATCH v7 net-next 07/10] net: dsa: microchip: add support for ethtool port counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49878826c61a9fe556869710fecee615cf2a0c21.camel@microchip.com>
Date:   Mon, 7 Feb 2022 22:33:25 +0530
From:   Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <andrew@...n.ch>, <netdev@...r.kernel.org>, <olteanv@...il.com>,
        <robh+dt@...nel.org>, <UNGLinuxDriver@...rochip.com>,
        <Woojung.Huh@...rochip.com>, <hkallweit1@...il.com>,
        <linux@...linux.org.uk>, <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <vivien.didelot@...il.com>,
        <f.fainelli@...il.com>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v7 net-next 07/10] net: dsa: microchip: add support for
 ethtool port counters

On Fri, 2022-02-04 at 19:27 -0800, Jakub Kicinski wrote:
> > +     for (i = 0; i < dev->mib_cnt; i++) {
> > +             memcpy(buf + i * ETH_GSTRING_LEN, lan937x_mib_names[i].string,
> > +                    ETH_GSTRING_LEN);
> > +     }
> 
> parenthesis unnecessary around single expression
> 
> Also check out ethtool_sprintf(), although not strictly necessary since
> you're not formatting
Sure, thanks for the feedback.

Prasanna V