linux-kernel - Re: [PATCH] thermal: netlink: Fix parameter type of thermal_genl_cpu_capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Feb 2022 20:47:03 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Nathan Chancellor <nathan@...nel.org>,
        srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] thermal: netlink: Fix parameter type of
 thermal_genl_cpu_capability_event() stub

On Mon, Feb 7, 2022 at 5:58 PM Nathan Chancellor <nathan@...nel.org> wrote:
>
> On Mon, Feb 07, 2022 at 08:54:41AM -0800, srinivas pandruvada wrote:
> > On Mon, 2022-02-07 at 09:38 -0700, Nathan Chancellor wrote:
> > > When building with CONFIG_THERMAL_NETLINK=n, there is a spew of
> > > warnings
> > > along the lines of:
> > >
> > >   In file included from drivers/thermal/thermal_core.c:27:
> > >   In file included from drivers/thermal/thermal_core.h:15:
> > >   drivers/thermal/thermal_netlink.h:113:71: warning: declaration of
> > > 'struct cpu_capability' will not be visible outside of this function
> > > [-Wvisibility]
> > >   static inline int thermal_genl_cpu_capability_event(int count,
> > > struct cpu_capability *caps)
> > >
> > >    ^
> > >   1 warning generated.
> > >
> > > 'struct cpu_capability' is not forward declared anywhere in the
> > > header.
> > > As it turns out, this should really be 'struct
> > > thermal_genl_cpu_caps',
> > > which silences the warning and makes the parameter types of the stub
> > > match the full function.
> > Thanks for sending the patch. I was about to send this change.
> > Since this patch target only linux-next, don't we need prefix:
> > "[PATCH -next]" instead of "[PATCH]"?
>
> I could probably get better about adding "-next" to the subject prefix
> to make it easier for maintainers but I do include the commit that the
> patch was based on at the bottom of the patch to accomplish the same
> thing.
>
> Thank you for the review!

Patch applied, thanks!