linux-kernel - Re: [PATCH 1/4] mm/memory_hotplug: remove obsolete comment of __add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220207121247.736ac7240836934247678477@linux-foundation.org>
Date:   Mon, 7 Feb 2022 12:12:47 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     David Hildenbrand <david@...hat.com>
Cc:     Miaohe Lin <linmiaohe@...wei.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] mm/memory_hotplug: remove obsolete comment of
 __add_pages

On Mon, 7 Feb 2022 15:41:21 +0100 David Hildenbrand <david@...hat.com> wrote:

> On 07.02.22 14:36, Miaohe Lin wrote:
> > Since commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded
> > memory to zones until online"), there is no need to pass in the zone.
> > 
> > Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> > ---
> >  mm/memory_hotplug.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> > index a4f69d399929..cbc67c27e0dd 100644
> > --- a/mm/memory_hotplug.c
> > +++ b/mm/memory_hotplug.c
> > @@ -296,10 +296,7 @@ struct page *pfn_to_online_page(unsigned long pfn)
> >  EXPORT_SYMBOL_GPL(pfn_to_online_page);
> >  
> >  /*
> > - * Reasonably generic function for adding memory.  It is
> > - * expected that archs that support memory hotplug will
> > - * call this function after deciding the zone to which to
> > - * add the new pages.
> > + * Reasonably generic function for adding memory.
> >   */
> >  int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
> >  		struct mhp_params *params)
> 
> I'd suggest just removing the comment completely.

Thanks, I made that change.

A better site for documentation is at add_memory().  Which, as a
full-on exported-to-modules API function, should really have some
docs...