linux-kernel - Re: [PATCH] selftests: Fix build when $(O) points to a relative path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <701fbfac-b548-1f05-7841-e233ef82be15@collabora.com>
Date:   Tue, 8 Feb 2022 01:59:58 +0500
From:   Muhammad Usama Anjum <usama.anjum@...labora.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     usama.anjum@...labora.com, Shuah Khan <shuah@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, kernel@...labora.com,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH] selftests: Fix build when $(O) points to a relative path

On 2/8/22 12:22 AM, Andrii Nakryiko wrote:
> On Fri, Feb 4, 2022 at 2:59 PM Muhammad Usama Anjum
> <usama.anjum@...labora.com> wrote:
>>
>> Build of bpf and tc-testing selftests fails when the relative path of
>> the build directory is specified.
>>
>> make -C tools/testing/selftests O=build0
>> make[1]: Entering directory '/linux_mainline/tools/testing/selftests/bpf'
>> ../../../scripts/Makefile.include:4: *** O=build0 does not exist.  Stop.
>> make[1]: Entering directory '/linux_mainline/tools/testing/selftests/tc-testing'
>> ../../../scripts/Makefile.include:4: *** O=build0 does not exist.  Stop.
>>
>> The fix is same as mentioned in commit 150a27328b68 ("bpf, preload: Fix
>> build when $(O) points to a relative path").
>>
> 
> I don't think it actually helps building BPF selftest. Even with this
This patch is fixing one type of build error which occurs if output
directory's path is relative.

> patch applied, all the feature detection doesn't work, and I get
> reallocarray redefinition failure when bpftool is being built as part
> of selftest.
There may be more problems in BPF tests. Those needs to be looked at
separately.

>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
>> ---
>>  tools/testing/selftests/Makefile | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
>> index 4eda7c7c15694..aa0faf132c35a 100644
>> --- a/tools/testing/selftests/Makefile
>> +++ b/tools/testing/selftests/Makefile
>> @@ -178,6 +178,7 @@ all: khdr
>>                 BUILD_TARGET=$$BUILD/$$TARGET;                  \
>>                 mkdir $$BUILD_TARGET  -p;                       \
>>                 $(MAKE) OUTPUT=$$BUILD_TARGET -C $$TARGET       \
>> +                               O=$(abs_objtree)                \
>>                                 $(if $(FORCE_TARGETS),|| exit); \
>>                 ret=$$((ret * $$?));                            \
>>         done; exit $$ret;
>> @@ -185,7 +186,8 @@ all: khdr
>>  run_tests: all
>>         @for TARGET in $(TARGETS); do \
>>                 BUILD_TARGET=$$BUILD/$$TARGET;  \
>> -               $(MAKE) OUTPUT=$$BUILD_TARGET -C $$TARGET run_tests;\
>> +               $(MAKE) OUTPUT=$$BUILD_TARGET -C $$TARGET run_tests \
>> +                               O=$(abs_objtree);                   \
>>         done;
>>
>>  hotplug:
>> --
>> 2.30.2
>>