linux-kernel - [PATCH] spi: spi-zynqmp-gqspi: fix for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2202072228170.52266@hadrien>
Date:   Mon, 7 Feb 2022 22:30:15 +0100 (CET)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Amit Kumar Mahapatra <amit.kumar-mahapatra@...inx.com>,
        Michal Simek <monstr@...str.eu>,
        Naga Sureshkumar Relli <naga.sureshkumar.relli@...inx.com>,
        Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org
cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kbuild-all@...ts.01.org, linux-arm-kernel@...ts.infradead.org
Subject: [PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings

From: kernel test robot <lkp@...el.com>

for_each_available_child_of_node should have of_node_put() before break.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: f0fcd7d14036 ("spi: spi-zynqmp-gqspi: Fix suspend/resume")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@...inx.com>
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: kernel test robot <lkp@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>

---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: f0fcd7d140361b1f54cfd76afb8c3afc9bf218a5 [857/872] spi: spi-zynqmp-gqspi: Fix suspend/resume
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago

Please take the patch only if it's a positive warning. Thanks!

 spi-zynqmp-gqspi.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -1395,6 +1395,7 @@ static int zynqmp_qspi_probe(struct plat
 					   &rx_bus_width);
 		if (!ret) {
 			xqspi->rx_bus_width = rx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}
@@ -1407,6 +1408,7 @@ static int zynqmp_qspi_probe(struct plat
 					   &tx_bus_width);
 		if (!ret) {
 			xqspi->tx_bus_width = tx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}