linux-kernel - Re: [PATCH v7 2/2] serial:sunplus-uart:Add Sunplus SoC UART Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgDHwgg0s6U3bFxF@kroah.com>
Date:   Mon, 7 Feb 2022 08:18:26 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Hammer Hsieh <hammerh0314@...il.com>
Cc:     robh+dt@...nel.org, linux-serial@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        jirislaby@...nel.org, p.zabel@...gutronix.de, wells.lu@...plus.com,
        hammer.hsieh@...plus.com
Subject: Re: [PATCH v7 2/2] serial:sunplus-uart:Add Sunplus SoC UART Driver

On Mon, Feb 07, 2022 at 01:58:01PM +0800, Hammer Hsieh wrote:
> Add Sunplus SoC UART Driver
> 

We need more of a changelog comment here please.  Describe the hardware,
what the new tty name you are using, and other stuff.  Be descriptive.

> --- a/include/uapi/linux/serial_core.h
> +++ b/include/uapi/linux/serial_core.h
> @@ -274,4 +274,7 @@
>  /* Freescale LINFlexD UART */
>  #define PORT_LINFLEXUART	122
>  
> +/* Sunplus UART */
> +#define PORT_SUNPLUS	123

Why is this needed?  Are you going to require this in some userspace
code?  If not, please do not add it.

thanks,

greg k-h