linux-kernel - Re: [PATCH] staging: octeon-usb: Fix 'should not end with '(''

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220207080935.GC1951@kadam>
Date:   Mon, 7 Feb 2022 11:09:35 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Joel Chang <joelcchangg@...il.com>
Cc:     Joe Perches <joe@...ches.com>,
        David Laight <David.Laight@...lab.com>,
        "linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "gregkh@...uxfoundation.com" <gregkh@...uxfoundation.com>
Subject: Re: [PATCH] staging: octeon-usb: Fix 'should not end with '(''

On Mon, Feb 07, 2022 at 09:57:34AM +0800, Joel Chang wrote:
> The hunk has two lines that end with '('. The hunk was rewritten but I
> believe the logic remains the same.
> 
> I agree they are longer than is 'nice', but they are still under 100 chars.

Just ignore checkpatch when it tempts you to make the code worse.

regards,
dan carpenter