linux-kernel - Re: [PATCH v2 4/8] VMCI: dma dg: set OS page size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D803905F-DA2C-421E-8D16-CAB16DE6F74A@vmware.com>
Date:   Mon, 7 Feb 2022 08:30:09 +0000
From:   Jorgen Hansen <jhansen@...are.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        Pv-drivers <Pv-drivers@...are.com>,
        Vishnu Dasa <vdasa@...are.com>
Subject: Re: [PATCH v2 4/8] VMCI: dma dg: set OS page size



> On 4 Feb 2022, at 16.12, Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> On Thu, Feb 03, 2022 at 05:12:33AM -0800, Jorgen Hansen wrote:
>> Tell the device the page size used by the OS.
>> 
>> Reviewed-by: Vishnu Dasa <vdasa@...are.com>
>> Signed-off-by: Jorgen Hansen <jhansen@...are.com>
>> ---
>> drivers/misc/vmw_vmci/vmci_guest.c | 9 +++++++++
>> include/linux/vmw_vmci_defs.h      | 1 +
>> 2 files changed, 10 insertions(+)
>> 
>> diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmci_guest.c
>> index 5a99d8e27873..808680dc0820 100644
>> --- a/drivers/misc/vmw_vmci/vmci_guest.c
>> +++ b/drivers/misc/vmw_vmci/vmci_guest.c
>> @@ -581,6 +581,15 @@ static int vmci_guest_probe_device(struct pci_dev *pdev,
>> 	/* Let the host know which capabilities we intend to use. */
>> 	vmci_write_reg(vmci_dev, caps_in_use, VMCI_CAPS_ADDR);
>> 
>> +	if (caps_in_use & VMCI_CAPS_DMA_DATAGRAM) {
>> +		uint32_t page_shift;
>> +
>> +		/* Let the device know the size for pages passed down. */
>> +		vmci_write_reg(vmci_dev, PAGE_SHIFT, VMCI_GUEST_PAGE_SHIFT);
>> +		page_shift = vmci_read_reg(vmci_dev, VMCI_GUEST_PAGE_SHIFT);
>> +		dev_info(&pdev->dev, "Using page shift %d\n", page_shift);
> 
> Please do not print out debugging stuff like this to the kernel log.

OK, I’ll remove it.

> When drivers are working properly, they are quiet.
> 
> thanks,
> 
> greg k-h

Thanks,
Jorgen