linux-kernel - Re: [PATCH] bus: mhi: Add mru_default for Quectel EM1xx series modules.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20220207084007.GE1905@thinkpad>
Date:   Mon, 7 Feb 2022 14:10:07 +0530
From:   Manivannan Sadhasivam <mani@...nel.org>
To:     Yonglin Tan <yonglin.tan@...look.com>
Cc:     hemantk@...eaurora.org, mhi@...ts.linux.dev,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: mhi: Add mru_default for Quectel EM1xx series
 modules.

On Fri, Jan 28, 2022 at 01:24:04PM +0800, Yonglin Tan wrote:
> For default mechanism, the driver uses default MRU 3500 if mru_default
> is not initialized. The Qualcomm configured the MRU size to 32768 in the
> WWAN device FW. So, we align the driver setting with Qualcomm FW setting.
> 
> Signed-off-by: Yonglin Tan <yonglin.tan@...look.com>

Please add the Fixes tag for commit ac4bf60bbaa0 and CC stable list.

Also the subject should be:
"bus: mhi: pci_generic: Add mru_default for Quectel EM1xx series"

With that,
Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>

Thanks,
Mani

> ---
>  drivers/bus/mhi/pci_generic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index b798958..9527b7d 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -327,6 +327,7 @@ static const struct mhi_pci_dev_info mhi_quectel_em1xx_info = {
>  	.config = &modem_quectel_em1xx_config,
>  	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>  	.dma_data_width = 32,
> +	.mru_default = 32768,
>  	.sideband_wake = true,
>  };
>  
> -- 
> 2.7.4
>