linux-kernel - Re: [PATCH v3 3/6] rtc: sun6i: Enable the bus clock when provided

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220207085633.q5ubv4v4iv4rg6rv@houat>
Date:   Mon, 7 Feb 2022 09:56:33 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        linux-sunxi@...ts.linux.dev,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Michael Turquette <mturquette@...libre.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-arm-kernel@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH v3 3/6] rtc: sun6i: Enable the bus clock when provided

On Wed, Feb 02, 2022 at 08:17:33PM -0600, Samuel Holland wrote:
> H6 and newer variants of the RTC hardware have a bus clock gate in the
> PRCM CCU. This was not known at the time H6 support was added, so it was
> not included in the H6 RTC binding, nor in the H6 PRCM CCU driver. Now
> that this clock gate is documented, it is included in the A100 and D1
> PRCM CCU drivers. Therefore, the RTC driver needs to have a consumer for
> the clock gate to prevent Linux from disabling it.
> 
> Patch-changes: 3
>  - New patch for compatibility with new CCU drivers

Did that creep in? Shouldn't it be in your changelog?

With that fixed,
Reviewed-by: Maxime Ripard <maxime@...no.tech>

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)