linux-kernel - Re: [PATCH] ARM: socfpga: fix missing RESET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Feb 2022 03:45:06 -0600
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Arnd Bergmann <arnd@...db.de>,
        Nathan Chancellor <nathan@...nel.org>,
        kernel test robot <lkp@...el.com>, stable@...r.kernel.org
Subject: Re: [PATCH] ARM: socfpga: fix missing RESET_CONTROLLER



On 2/7/22 02:44, Krzysztof Kozlowski wrote:
> The SocFPGA machine since commit b3ca9888f35f ("reset: socfpga: add an
> early reset driver for SoCFPGA") uses reset controller, so it should
> select RESET_CONTROLLER explicitly.  Selecting ARCH_HAS_RESET_CONTROLLER
> is not enough because it affects only default choice still allowing a
> non-buildable configuration:
> 
>    /usr/bin/arm-linux-gnueabi-ld: arch/arm/mach-socfpga/socfpga.o: in function `socfpga_init_irq':
>    arch/arm/mach-socfpga/socfpga.c:56: undefined reference to `socfpga_reset_init'
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: <stable@...r.kernel.org>
> Fixes: b3ca9888f35f ("reset: socfpga: add an early reset driver for SoCFPGA")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
>   arch/arm/mach-socfpga/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig
> index 43ddec677c0b..594edf9bbea4 100644
> --- a/arch/arm/mach-socfpga/Kconfig
> +++ b/arch/arm/mach-socfpga/Kconfig
> @@ -2,6 +2,7 @@
>   menuconfig ARCH_INTEL_SOCFPGA
>   	bool "Altera SOCFPGA family"
>   	depends on ARCH_MULTI_V7
> +	select ARCH_HAS_RESET_CONTROLLER
>   	select ARCH_SUPPORTS_BIG_ENDIAN
>   	select ARM_AMBA
>   	select ARM_GIC
> @@ -18,6 +19,7 @@ menuconfig ARCH_INTEL_SOCFPGA
>   	select PL310_ERRATA_727915
>   	select PL310_ERRATA_753970 if PL310
>   	select PL310_ERRATA_769419
> +	select RESET_CONTROLLER
>   
>   if ARCH_INTEL_SOCFPGA
>   config SOCFPGA_SUSPEND

Acked-By: Dinh Nguyen <dinguyen@...nel.org>