linux-kernel - Re: [PATCH v4 1/5] mm: Fix invalid page pointer returned with FOLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a5e9fac-7597-80b6-1cc8-9818b8ff73cd@nvidia.com>
Date:   Sun, 6 Feb 2022 21:19:35 -0800
From:   John Hubbard <jhubbard@...dia.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Peter Xu <peterx@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>,
        David Hildenbrand <david@...hat.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        Matthew Wilcox <willy@...radead.org>, Jan Kara <jack@...e.cz>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org
Subject: Re: [PATCH v4 1/5] mm: Fix invalid page pointer returned with
 FOLL_PIN gups

On 2/3/22 23:25, Christoph Hellwig wrote:
> On Thu, Feb 03, 2022 at 06:00:06PM -0800, John Hubbard wrote:
>> From: Peter Xu <peterx@...hat.com>
>>
>> Alex reported invalid page pointer returned with pin_user_pages_remote() from
>> vfio after upstream commit 4b6c33b32296 ("vfio/type1: Prepare for batched
>> pinning with struct vfio_batch").
> 
> This commit message uses overly long lines all over.

I'll reflow it to 72 columns and post a v5 with the full set of
reviewed-by tags.

> 
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>

I appreciate the reviews, from you and everyone, as always.


thanks,
-- 
John Hubbard
NVIDIA