linux-kernel - Re: [PATCH 1/2] i2c: hisi: Add generic GPIO bus recovery support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgD/3Xi0yLPHCu+L@smile.fi.intel.com>
Date:   Mon, 7 Feb 2022 13:17:49 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Yicong Yang <yangyicong@...ilicon.com>
Cc:     jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com,
        wsa@...nel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, prime.zeng@...ilicon.com,
        linuxarm@...wei.com
Subject: Re: [PATCH 1/2] i2c: hisi: Add generic GPIO bus recovery support

On Tue, Jan 25, 2022 at 08:49:29PM +0800, Yicong Yang wrote:
> Add generic GPIO bus recovery support for i2c-hisi driver
> by registering the recovery information with core provided
> i2c_generic_scl_recovery() method.
> 
> As the SCL/SDA pins are multiplexed with GPIO, we need to
> switch the pins mux to GPIO before recovery and switch back
> after recovery. It's implemented by the ACPI method in
> the i2c_bus_recovery_info->{prepare,unprepare}_recovery()
> method.

NAK.

ACPI has its own resources for that. What is missed is the layer between ACPI
and pin control.

-- 
With Best Regards,
Andy Shevchenko