lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220208160112.GG4160@nvidia.com> Date: Tue, 8 Feb 2022 12:01:12 -0400 From: Jason Gunthorpe <jgg@...dia.com> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@...wei.com> Cc: "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>, "alex.williamson@...hat.com" <alex.williamson@...hat.com>, "cohuck@...hat.com" <cohuck@...hat.com>, "mgurtovoy@...dia.com" <mgurtovoy@...dia.com>, "yishaih@...dia.com" <yishaih@...dia.com>, Linuxarm <linuxarm@...wei.com>, liulongfang <liulongfang@...wei.com>, "Zengtao (B)" <prime.zeng@...ilicon.com>, Jonathan Cameron <jonathan.cameron@...wei.com>, "Wangzhou (B)" <wangzhou1@...ilicon.com> Subject: Re: [RFC v4 7/8] hisi_acc_vfio_pci: Add support for VFIO live migration On Tue, Feb 08, 2022 at 03:48:16PM +0000, Shameerali Kolothum Thodi wrote: > > > +static int hisi_acc_vfio_pci_init(struct hisi_acc_vf_core_device > > *hisi_acc_vdev) > > > +{ > > > + struct vfio_pci_core_device *vdev = &hisi_acc_vdev->core_device; > > > + struct pci_dev *vf_dev = vdev->pdev; > > > + struct hisi_qm *vf_qm = &hisi_acc_vdev->vf_qm; > > > + > > > + /* > > > + * ACC VF dev BAR2 region consists of both functional register space > > > + * and migration control register space. For migration to work, we > > > + * need access to both. Hence, we map the entire BAR2 region here. > > > + * But from a security point of view, we restrict access to the > > > + * migration control space from Guest(Please see mmap/ioctl/read/write > > > + * override functions). > > > + * > > > + * Also the HiSilicon ACC VF devices supported by this driver on > > > + * HiSilicon hardware platforms are integrated end point devices > > > + * and has no capability to perform PCIe P2P. > > > + */ > > > + vf_qm->io_base = > > > + ioremap(pci_resource_start(vf_dev, VFIO_PCI_BAR2_REGION_INDEX), > > > + pci_resource_len(vf_dev, VFIO_PCI_BAR2_REGION_INDEX)); > > > + if (!vf_qm->io_base) > > > + return -EIO; > > > + > > > + vf_qm->fun_type = QM_HW_VF; > > > + vf_qm->pdev = vf_dev; > > > + mutex_init(&vf_qm->mailbox_lock); > > > > mailbox_lock seems unused > > I think we need that as that will be used in the QM driver APIs. I will add a > comment here. Perhaps you need some 'init hisi_qm' function to make this more clear instead of opening coding initing so other module's structure? Jason
Powered by blists - more mailing lists