linux-kernel - Re: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220208161031.3jknptcqcc7sltwk@skbuf>
Date:   Tue, 8 Feb 2022 16:10:32 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Colin Foster <colin.foster@...advantage.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Manoil <claudiu.manoil@....com>
Subject: Re: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for
 stats

On Tue, Feb 08, 2022 at 08:07:42AM -0800, Colin Foster wrote:
> # ethtool -S swp1 | head -n 5
> NIC statistics:
>      tx_packets: 942
>      tx_bytes: 48984
>      rx_packets: 764
>      rx_bytes: 37808
> # ethtool -S swp2 | head -n 5
> NIC statistics:
>      tx_packets: 946
>      tx_bytes: 49192
>      rx_packets: 1
>      rx_bytes: 46
> # ethtool -S swp3 | head -n 5
> NIC statistics:
>      tx_packets: 1
>      tx_bytes: 52
>      rx_packets: 1699
>      rx_bytes: 80658
> # ethtool -S swp4 | head -n 5
> NIC statistics:
>      tx_packets: 0
>      tx_bytes: 0
>      rx_packets: 0
>      rx_bytes: 0

I understand what confused you now. These are software counters patched
in by dsa_slave_get_ethtool_stats(). They are in no way the counters
from felix_info :: stats_layout, please compare the strings!