lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YgK6k4TXnRbm02dh@slm.duckdns.org> Date: Tue, 8 Feb 2022 08:46:43 -1000 From: Tejun Heo <tj@...nel.org> To: Namhyung Kim <namhyung@...nel.org> Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>, Will Deacon <will@...nel.org>, Waiman Long <longman@...hat.com>, Boqun Feng <boqun.feng@...il.com>, LKML <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, Steven Rostedt <rostedt@...dmis.org>, Byungchul Park <byungchul.park@....com>, "Paul E. McKenney" <paul.mckenney@...aro.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Radoslaw Burny <rburny@...gle.com>, Zefan Li <lizefan.x@...edance.com>, Johannes Weiner <hannes@...xchg.org>, cgroups@...r.kernel.org Subject: Re: [PATCH 02/12] cgroup: rstat: Make cgroup_rstat_cpu_lock name readable On Tue, Feb 08, 2022 at 10:41:58AM -0800, Namhyung Kim wrote: > The raw_spin_lock_init() uses the argument to name its lockdep map. > But passing per_cpu_ptr() macro directly makes it a very very long > name as it expanded like below: > > ({ do { const void *__vpp_verify = (typeof((&cgroup_rstat_cpu_lock) ... > > Let's fix it by passing a local variable instead. With this change, > the name now looks like: > > cgrp_rstat_cpu_lock > > Cc: Tejun Heo <tj@...nel.org> > Cc: Zefan Li <lizefan.x@...edance.com> > Cc: Johannes Weiner <hannes@...xchg.org> > Cc: cgroups@...r.kernel.org > Signed-off-by: Namhyung Kim <namhyung@...nel.org> Acked-by: Tejun Heo <tj@...nel.org> but maybe add a comment explaining what's going on? Thanks. -- tejun
Powered by blists - more mailing lists