linux-kernel - Re: [peterz-queue:sched/core 32/32] arch/arm64/include/asm/preempt.h:85:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YgK7I2bMJQA8IPmt@FVFF77S0Q05N>
Date:   Tue, 8 Feb 2022 18:49:07 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [peterz-queue:sched/core 32/32]
 arch/arm64/include/asm/preempt.h:85:1: error: type defaults to 'int' in
 declaration of 'DECLARE_STATIC_KEY_TRUE'

On Tue, Feb 08, 2022 at 07:08:33PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
> head:   ac7695a93a578befdcf4900a90860bf19e057e1b
> commit: ac7695a93a578befdcf4900a90860bf19e057e1b [32/32] arm64: support PREEMPT_DYNAMIC

> >> arch/arm64/include/asm/preempt.h:85:1: warning: data definition has no type or storage class
>       85 | DECLARE_STATIC_KEY_TRUE(sk_dynamic_irqentry_exit_cond_resched);
>          | ^~~~~~~~~~~~~~~~~~~~~~~

This is because I forgot to include <linux/jump_label.h>, so GCC has no idea
what `DECLARE_STATIC_KEY_TRUE` means.

I'll go add that where needed and check that doesn't introduce a circular
dependency.

Thanks,
Mark.