linux-kernel - Re: [PATCH 03/12] timer: Protect lockdep functions with #ifdef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220208161954.4adde540@gandalf.local.home>
Date:   Tue, 8 Feb 2022 16:19:54 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>, Will Deacon <will@...nel.org>,
        Waiman Long <longman@...hat.com>,
        Boqun Feng <boqun.feng@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Byungchul Park <byungchul.park@....com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Radoslaw Burny <rburny@...gle.com>,
        "Paul E. McKenney" <paulmck@...nel.org>
Subject: Re: [PATCH 03/12] timer: Protect lockdep functions with #ifdef

On Tue, 8 Feb 2022 12:29:32 -0800
Namhyung Kim <namhyung@...nel.org> wrote:

> Hi Steve,
> 
> On Tue, Feb 8, 2022 at 11:36 AM Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > On Tue,  8 Feb 2022 10:41:59 -0800
> > Namhyung Kim <namhyung@...nel.org> wrote:
> >  
> > > With upcoming lock tracepoints config, it'd define some of lockdep
> > > functions without enabling CONFIG_LOCKDEP actually.  The existing code
> > > assumes those functions will be removed by the preprocessor but it's
> > > not the case anymore.  Let's protect the code with #ifdef's explicitly.  
> >
> > I wonder if it would be cleaner to have another macro name for these
> > locations to keep out the ugly #ifdef in the code.
> >
> > lockdep_init_map_raw() ?  
> 
> Yeah, I like that..  Then I also need to add the _raw variants
> for acquire, release and so on.  Is that ok?
>

Yeah, most definitely.

Thanks,

-- Steve