linux-kernel - Re: [PATCH 2/2] ARM: dts: kirkwood: Add Ctera C-200 V1 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgHOup5cKZJyxWFB@lunn.ch>
Date:   Tue, 8 Feb 2022 03:00:26 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Pawel Dembicki <paweldembicki@...il.com>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: kirkwood: Add Ctera C-200 V1 board

On Mon, Feb 07, 2022 at 10:20:14PM +0100, Pawel Dembicki wrote:
> Ctera C200 V1 is kirkwood-based 2-Bay NAS.
> 
> Hardware:
>   - SoC: Marvell 88F6281-A1 ARMv5TE Processor 1.2GHz
>   - Ram: 512MB (4x Nanya NT5TU128M8GE-AC)
>   - NAND Flash: 256MB (Samsung 216 K9F2G08U0C)
>   - Lan: 1x GBE (Marvell 88E1116R-NNC1)
>   - Storage: 2x SATA HDD 3.5" Slot
>   - USB: 2x USB 2.0 port
>   - Console: Internal J3 connector (1: Vcc, 2: Rx, 3: Tx, 4: GND)
>   - LEDs: 13x GPIO controlled
>   - Buttons: 2x GPIO controlled
> 
> Signed-off-by: Pawel Dembicki <paweldembicki@...il.com>

Hi Pawel

It is a good idea to Cc: the mvebu maintainers, since kirkwood is part
of that.

> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-0 = <&pmx_leds>;
> +		pinctrl-names = "default";
> +
> +

Please avoid 2 blank lines. This happens a few times in this file.

> +&pciec {
> +	status = "okay";
> +};

It would be nice to have a comment about what is on the PCIe bus. Or
is it just a socket?

> +
> +&pcie0 {
> +	status = "okay";
> +};
> +
> +&pinctrl {
> +	/* buzzer gpios are connected to two pins of buzzer
> +	 * leave it as is due lack of proper driver
> +	 */
> +	pmx_buzzer: pmx-buzzer {
> +		marvell,pins = "mpp12", "mpp13";
> +		marvell,function = "gpio";
> +	};

Is it possible to use "gpio-beeper"?

        beeper: beeper {
                /* 4KHz Piezoelectric buzzer */
                compatible = "gpio-beeper";
                pinctrl-0 = <&pmx_beeper>;
                pinctrl-names = "default";
                gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
        };

	Andrew