linux-kernel - Re: [PATCH v2 15/31] clk: mediatek: Implement mtk_clk_unregister_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Feb 2022 11:50:42 +0800
From:   Chen-Yu Tsai <wenst@...omium.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Chun-Jie Chen <chun-jie.chen@...iatek.com>,
        Miles Chen <miles.chen@...iatek.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 15/31] clk: mediatek: Implement mtk_clk_unregister_fixed_clks()
 API

Hi,

On Thu, Feb 3, 2022 at 5:47 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com> wrote:
>
> Il 02/02/22 14:48, Chen-Yu Tsai ha scritto:
> > mtk_clk_register_fixed_clks(), as the name suggests, is used to register
> > a given list of fixed rate clks. However it is lacking a counterpart
> > unregister API.
> >
> > Implement said unregister API so that the various clock platform drivers
> > can utilize it to do proper unregistration, cleanup and removal.
> >
> > In the header file, the register function's declaration is also
> > reformatted to fit code style guidelines.
> >
> > Signed-off-by: Chen-Yu Tsai <wenst@...omium.org>
> > Reviewed-by: Miles Chen <miles.chen@...iatek.com>
>
> Hello Chen-Yu,
>
> I like this entire series, but I had to manually apply this patch (and some of
> the other ones)...

This was based on linux-next, which already has a couple clk patches queued
up.

> Especially for the ones that will be touching MT8195 clock drivers, can you
> please rebase over series [1] by Chun-Jie?

I think this series supersedes the first patch in that series? As for the
other two, I think the discussion about the bindings is ongoing, which
might affect the third patch as well?

ChenYu

> [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=603955
>
> Thanks,
> Angelo
>