linux-kernel - Re: [PATCH v2] dmaengine: ptdma: Fix the error handling path in pt_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa78a0f9-9bd1-5c24-f834-61085d9fe3a4@amd.com>
Date:   Tue, 8 Feb 2022 09:54:06 +0530
From:   Sanjay R Mehta <sanmehta@....com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Sanjay R Mehta <sanju.mehta@....com>,
        Vinod Koul <vkoul@...nel.org>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH v2] dmaengine: ptdma: Fix the error handling path in
 pt_core_init()



On 2/7/2022 10:21 PM, Dan Carpenter wrote:
> On Sat, Feb 05, 2022 at 07:58:44AM +0100, Christophe JAILLET wrote:
>> In order to free resources correctly in the error handling path of
>> pt_core_init(), 2 goto's have to be switched. Otherwise, some resources
>> will leak and we will try to release things that have not been allocated
>> yet.
>>
>> Also move a dev_err() to a place where it is more meaningful.
>>
>> Fixes: fa5d823b16a9 ("dmaengine: ptdma: Initial driver for the AMD PTDMA")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>> ---
>> v2: update label names
>>     move dev_err(dev, "unable to allocate an IRQ\n");
> 
> Awesome.  Thanks!
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

Thank you!

Acked-by: Sanjay R Mehta <sanju.mehta@....com>
> 
> regards,
> dan carpenter
>