lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <17ed816b6f3.d4fb44fb69745.1048447841721382920@zohomail.com> Date: Tue, 08 Feb 2022 01:47:54 -0500 From: Li Chen <lchen.firstlove@...omail.com> To: "Kishon Vijay Abraham I" <kishon@...com>, "Lorenzo Pieralisi" <lorenzo.pieralisi@....com>, "Krzysztof WilczyĆski" <kw@...ux.com>, "Bjorn Helgaas" <bhelgaas@...gle.com>, "linux-pci" <linux-pci@...r.kernel.org>, "linux-kernel" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] PCI: endpoint fix misused goto label ping ---- On Fri, 21 Jan 2022 02:48:23 -0500 Li Chen <lchen.firstlove@...omail.com> wrote ---- > From: Li Chen <lchen@...arella.com> > > If we goto err_map_addr here, buf allocated > via kmalloc won't get freeed, then memoryleak. > > Signed-off-by: Li Chen <lchen@...arella.com> > --- > drivers/pci/endpoint/functions/pci-epf-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index 96489cfdf58db..60303223976a1 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -441,7 +441,7 @@ static int pci_epf_test_write(struct pci_epf_test *epf_test) > if (!epf_test->dma_supported) { > dev_err(dev, "Cannot transfer data using DMA\n"); > ret = -EINVAL; > - goto err_map_addr; > + goto err_dma_map; > } > > src_phys_addr = dma_map_single(dma_dev, buf, reg->size, > -- > 2.34.1 > > >
Powered by blists - more mailing lists