linux-kernel - Re: [PATCH v4 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <00c5b899-ed35-44a0-6b22-bc3e882e49d4@amd.com>
Date:   Tue, 8 Feb 2022 09:33:14 +0100
From:   Christian König <christian.koenig@....com>
To:     zhanglianjie <zhanglianjie@...ontech.com>
Cc:     Alex Deucher <alexander.deucher@....com>,
        PanXinhui <Xinhui.Pan@....com>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects

I think so, Alex will probably pick that up.

Thanks,
Christian.

Am 08.02.22 um 09:28 schrieb zhanglianjie:
> I am very sorry that I submitted many times due to the character 
> coding problem. Can PATCH V4 be used?
>
>> I'm scratching my head what you are doing here?
>>
>> That's the fives time you send out the same patch, so something is 
>> going wrong here :)
>>
>> Please double check why that lands in your outbox over and over again.
>>
>> Regards,
>> Christian.
>>
>> Am 08.02.22 um 09:14 schrieb zhanglianjie:
>>> after the buffer object is successfully mapped, call 
>>> radeon_bo_kunmap before the function returns.
>>>
>>> Signed-off-by: zhanglianjie <zhanglianjie@...ontech.com>
>>> Reviewed-by: Christian König <christian.koenig@....com>
>>>
>>> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c 
>>> b/drivers/gpu/drm/radeon/radeon_uvd.c
>>> index 377f9cdb5b53..0558d928d98d 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
>>> @@ -497,6 +497,7 @@ static int radeon_uvd_cs_msg(struct 
>>> radeon_cs_parser *p, struct radeon_bo *bo,
>>>       handle = msg[2];
>>>
>>>       if (handle == 0) {
>>> +        radeon_bo_kunmap(bo);
>>>           DRM_ERROR("Invalid UVD handle!\n");
>>>           return -EINVAL;
>>>       }
>>> @@ -559,12 +560,10 @@ static int radeon_uvd_cs_msg(struct 
>>> radeon_cs_parser *p, struct radeon_bo *bo,
>>>           return 0;
>>>
>>>       default:
>>> -
>>>           DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type);
>>> -        return -EINVAL;
>>>       }
>>>
>>> -    BUG();
>>> +    radeon_bo_kunmap(bo);
>>>       return -EINVAL;
>>>   }
>>>
>>> -- 
>>> 2.20.1
>>>
>>>
>>>
>>
>>
>
>
>