linux-kernel - Re: [PATCH v4 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220208091028.GA3679538@anxtwsw-Precision-3640-Tower>
Date:   Tue, 8 Feb 2022 17:10:28 +0800
From:   Xin Ji <xji@...logixsemi.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        bliang@...logixsemi.com, qwen@...logixsemi.com,
        jli@...logixsemi.com, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v4 2/2] usb: typec: anx7411: Add Analogix PD ANX7411
 support

On Tue, Feb 08, 2022 at 09:48:16AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 08, 2022 at 04:42:39PM +0800, Xin Ji wrote:
> > +#define DEBUG
> 
> Please no.  Rely on dynamic debugging options, not hard-coded ones like
> this.
> 
> Please remove this.
Hi Greg k-h, thanks for your comment, I'll remove it in the next version.

Thanks,
Xin
> 
> thanks,
> 
> greg k-h