linux-kernel - Re: [PATCH 1/4] mm/memory_hotplug: remove obsolete comment of __add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af295749-bb1b-a277-e745-3a246928331a@huawei.com>
Date:   Tue, 8 Feb 2022 18:56:53 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Oscar Salvador <osalvador@...e.de>
CC:     <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] mm/memory_hotplug: remove obsolete comment of
 __add_pages

On 2022/2/8 18:15, Oscar Salvador wrote:
> On Mon, Feb 07, 2022 at 09:36:40PM +0800, Miaohe Lin wrote:
>> Since commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded
>> memory to zones until online"), there is no need to pass in the zone.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> 
> Yeah, I am with David here, "Reasonably generic function for adding
> memory" does not really tell me much about that function.
>  

Agree with you. And Andrew have kindly made that change.
Many thanks for your review. :)