linux-kernel - Re: [RFC PATCH v4 03/13] module: Move livepatch support to a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Feb 2022 15:18:53 +0000
From:   Aaron Tomlin <atomlin@...hat.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     mcgrof@...nel.org, cl@...ux.com, mbenes@...e.cz,
        akpm@...ux-foundation.org, jeyu@...nel.org,
        linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org,
        live-patching@...r.kernel.org, atomlin@...mlin.com,
        ghalat@...hat.com, allen.lkml@...il.com, void@...ifault.com,
        joe@...ches.com
Subject: Re: [RFC PATCH v4 03/13] module: Move livepatch support to a
 separate file

On Tue 2022-02-08 12:42 +0100, Petr Mladek wrote:
> This should go to internal.h.
> 
> Alternative is to move both is_livepatch_module() and
> set_livepatch_module() into include/linux/livepatch.h.
> 
> I do not have strong opinion.

Hi Petr,

Firstly, thank you for your feedback.

In my opinion, I believe is_livepatch_module() should remain as it may
continue to be used externally i.e., outside of kernel/module/; albeit,
indeed set_livepatch_module() should be moved to kernel/module/internal.h
given its use is exclusive to core code.


Kind regards,

-- 
Aaron Tomlin