lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Feb 2022 17:05:19 +0100 From: Javier Martinez Canillas <javierm@...hat.com> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: linux-kernel@...r.kernel.org, Thomas Zimmermann <tzimmermann@...e.de>, Noralf Trønnes <noralf@...nnes.org>, Maxime Ripard <maxime@...no.tech>, Geert Uytterhoeven <geert@...ux-m68k.org>, linux-fbdev@...r.kernel.org, Daniel Vetter <daniel.vetter@...ll.ch>, Sam Ravnborg <sam@...nborg.org>, dri-devel@...ts.freedesktop.org, Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...ux.ie> Subject: Re: [PATCH v3 4/7] drm/solomon: Add SSD130X OLED displays I2C support On 2/9/22 16:15, Andy Shevchenko wrote: > On Wed, Feb 09, 2022 at 10:03:11AM +0100, Javier Martinez Canillas wrote: >> The ssd130x driver only provides the core support for these devices but it >> does not have any bus transport logic. Add a driver to interface over I2C. > > Thanks! > > ... > >> + * Authors: Javier Martinez Canillas <javierm@...hat.com> > > s?! > Right. > ... > >> +#include <linux/i2c.h> >> +#include <linux/module.h> > > regmap.h ? > err.h? > The regmap.h header is included in ssd130x.h and err.h in regmap.h. > ... > >> + ssd130x = ssd130x_probe(&client->dev, regmap); > >> + > > Redundant blank line. > Ok. >> + if (IS_ERR(ssd130x)) >> + return PTR_ERR(ssd130x); > > ... > >> + { /* sentinel */ }, > > No comma for terminator entry. > > Right. I removed in one place bug forgot here. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat
Powered by blists - more mailing lists