linux-kernel - Re: [PATCH] watchdog: Improve watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <055fcdfe-3e18-0bdc-817a-a51049978803@kernel.org>
Date:   Wed, 9 Feb 2022 18:01:13 +0100
From:   Daniel Bristot de Oliveira <bristot@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] watchdog: Improve watchdog_dev function documentation

On 2/9/22 17:51, Randy Dunlap wrote:
> Hi Daniel,
> 
> On 2/9/22 01:08, Daniel Bristot de Oliveira wrote:
>> Adjust function comments to the kernel doc format. It
>> also adjusts some variable names and adds return values.
>>
>> No functional change.
> After applying the patch, I still see 3 warnings:
> 
> watchdog_dev.c:1127: warning: No description found for return value of 'watchdog_dev_register'
> watchdog_dev.c:1169: warning: No description found for return value of 'watchdog_set_last_hw_keepalive'
> watchdog_dev.c:1197: warning: No description found for return value of 'watchdog_dev_init'
> 
> 
> Ah, I see. The format for function Return in kernel-doc is:
> 
>  * Return: func return info here
> 

Ack, I will fix that.

Thanks, Randy!
-- Daniel