linux-kernel - Re: [PATCH 3/3] spi: amd: Add support for version AMDI0062

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Feb 2022 14:29:53 -0300
From:   André Almeida <andrealmeid@...labora.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Sanjay R Mehta <sanju.mehta@....com>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com,
        Lucas Tanure <tanureal@...nsource.cirrus.com>,
        Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@....com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>
Subject: Re: [PATCH 3/3] spi: amd: Add support for version AMDI0062

Às 14:28 de 09/02/22, Mark Brown escreveu:
> On Wed, Feb 09, 2022 at 02:18:59PM -0300, André Almeida wrote:
>> Às 14:14 de 09/02/22, Mark Brown escreveu:
> 
>>>> +
>>>> +	if (amd_spi->version == AMD_SPI_V2)
>>>> +		amd_spi_clear_chip(amd_spi, message->spi->chip_select);
>>>>  	spi_finalize_current_message(master);
>>>>  
>>>>  	return 0;
> 
>>> Why is this one not a switch statement - what happens with v3?
> 
>> A switch statement should work as well, but currently v1 does nothing
>> and there's no v3 for now. I think we can change for a switch if v3
>> requires to do something here as well.
> 
> Please write it in an extensible fashion now so people aren't tempted to
> add an if/else tree.

Got it, I will fix it for the next patch version, thanks!