linux-kernel - Re: [PATCH] staging: r8188eu: keep the success path and error path separate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be19eaee-2b90-d0c3-c80c-d8fb379bdcf3@gmail.com>
Date:   Wed, 9 Feb 2022 21:33:50 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Vihas Makwana <makvihas@...il.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>,
        Martin Kaiser <martin@...ser.cx>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: keep the success path and error path
 separate

Hi Vihas,

On 2/9/22 20:48, Vihas Makwana wrote:
> -exit:
> +	if (pnetdev)
> +		rtw_free_netdev(pnetdev);
> +	else if (padapter)
> +		vfree(padapter);
> +	padapter = NULL;
> +
>   	return padapter;
>   }

Why just not `return NULL`?




With regards,
Pavel Skripkin