linux-kernel - Re: [PATCHv9 1/5] arm64: io: Use asm-generic high level MMIO accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgQNiXsh4hC+5+O5@arm.com>
Date:   Wed, 9 Feb 2022 18:52:57 +0000
From:   Catalin Marinas <catalin.marinas@....com>
To:     Sai Prakash Ranjan <quic_saipraka@...cinc.com>
Cc:     Will Deacon <will@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Marc Zyngier <maz@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        gregkh <gregkh@...uxfoundation.org>, quic_psodagud@...cinc.com,
        Trilok Soni <quic_tsoni@...cinc.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCHv9 1/5] arm64: io: Use asm-generic high level MMIO
 accessors

On Mon, Jan 24, 2022 at 12:03:30PM +0530, Sai Prakash Ranjan wrote:
> Remove custom arm64 MMIO accessors read{b,w,l,q} and their relaxed
> versions in support to use asm-generic defined accessors. Also define
> one set of IO barriers (ar/bw version) used by asm-generic code to
> override the arm64 specific variants.
> 
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@...cinc.com>

I'm fine with this patch:

Acked-by: Catalin Marinas <catalin.marinas@....com>

> diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
> index 7fd836bea7eb..1b436810d779 100644
> --- a/arch/arm64/include/asm/io.h
> +++ b/arch/arm64/include/asm/io.h
[...]
> +/* arm64-specific, don't use in portable drivers */
> +#define __iormb(v)		__io_ar(v)
> +#define __iowmb()		__io_bw()
> +#define __iomb()		dma_mb()

However, I'd like to see a few subsequent patches that get rid of the
__io*mb() uses in drivers/ (there don't seem to be that many).

-- 
Catalin