[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YgMy/CYL8lmf6Y+J@robh.at.kernel.org>
Date: Tue, 8 Feb 2022 21:20:28 -0600
From: Rob Herring <robh@...nel.org>
To: Hugo Villeneuve <hugo@...ovil.com>
Cc: Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Hugo Villeneuve <hvilleneuve@...onoff.com>,
linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/10] dt-bindings: rtc: pcf2127: add PCF2131 INT_A and
INT_B support
On Tue, Jan 25, 2022 at 03:00:09PM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@...onoff.com>
>
> The PCF2131 has two output interrupt pins, named INT_A and INT_B.
>
> Add properties to identify onto which pin we want the alarm interrupt
> to be routed. It can be either one, or both.
>
> These properties are automatically set to false for variants other
> than PCF2131 (ex: PCF2127).
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> ---
> .../devicetree/bindings/rtc/nxp,pcf2127.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> index 57eb0a58afa3..83656dd2f97f 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -24,6 +24,16 @@ properties:
> interrupts:
> maxItems: 1
>
> + alarm-output-a:
nxp,alarm-output-a
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + Enable alarm interrupt on INT_A output pin.
> +
> + alarm-output-b:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + Enable alarm interrupt on INT_B output pin.
> +
> start-year: true
>
> reset-source: true
> @@ -32,6 +42,18 @@ required:
> - compatible
> - reg
>
> +if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - nxp,pcf2131
> +then:
> + properties:
> + alarm-output-a: false
> + alarm-output-b: false
> +
> additionalProperties: false
>
> examples:
> @@ -62,6 +84,7 @@ examples:
> pinctrl-0 = <&rtc_nint_pins>;
> interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
> reset-source;
> + alarm-output-b;
> };
> };
>
> --
> 2.30.2
>
>
Powered by blists - more mailing lists