linux-kernel - Re: Re: [PATCH 2/2] soc: s4: Add support for power domains controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7hee4bok8w.fsf@baylibre.com>
Date:   Wed, 09 Feb 2022 12:30:55 -0800
From:   Kevin Hilman <khilman@...libre.com>
To:     "shunzhou.jiang@...ogic.com" <shunzhou.jiang@...ogic.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-amlogic <linux-amlogic@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Cc:     Neil Armstrong <narmstrong@...libre.com>,
        jbrunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        "jianxin.pan" <jianxin.pan@...ogic.com>
Subject: Re: Re: [PATCH 2/2] soc: s4: Add support for power domains controller

"shunzhou.jiang@...ogic.com" <shunzhou.jiang@...ogic.com> writes:

> Hi  Kevin:
> Thanks your reply.
> Please refer to below comment,
>> S4_VPU_HDMI:  for vpu domain,  this domain provide power to many moudles(osd, vpp, hdr, dv, di), if close, will cause system crash
>> S4_USB_COMB domain: for usb, if not always on,  all usb status will clear to 0, that's not right status for usb

Yes, I understand, this is teh same as for other SoCs (e.g. A1.)   The
solution is not to set the domain to always on.  The solution is for the
drivers for the devices in these domains use runtime PM so that when the
drivers are active, the power domain does not get shut off.

>> S4_ETH: for ethernet online wakeup, and if power down, status also not right

OK, this one makes sense for "always on" since it used by firmware for
wakeup.

Kevin