linux-kernel - Re: [PATCH v1 1/1] crypto: qat - don't cast parameter in bit operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgQoa/8OXXFl4qUo@silpixa00400314>
Date:   Wed, 9 Feb 2022 20:47:39 +0000
From:   Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Jack Xu <jack.xu@...el.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Zhehui Xiang <zhehui.xiang@...el.com>, qat-linux@...el.com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v1 1/1] crypto: qat - don't cast parameter in bit
 operations

Thanks Andy.

On Wed, Feb 09, 2022 at 08:00:47PM +0200, Andy Shevchenko wrote:
> While in this particular case it would not be a (critical) issue,
> the pattern itself is bad and error prone in case the location
> of the parameter is changed.
> 
> Don't cast parameter to unsigned long pointer in the bit operations.
> Instead copy to a local variable on stack of a proper type and use.
> 
> Fixes: b4b7e67c917f ("crypto: qat - Intel(R) QAT ucode part of fw loader")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>

-- 
Giovanni